Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make symbols_count_time faster #862

Merged
merged 5 commits into from
May 3, 2019
Merged

Make symbols_count_time faster #862

merged 5 commits into from
May 3, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented May 3, 2019

Related to theme-next/hexo-symbols-count-time#23

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

Only plugin update needed:

$ cd hexo
$ npm update hexo-symbols-count-time

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx ivan-nginx added this to the 7.2.0 milestone May 3, 2019
@ivan-nginx ivan-nginx changed the title Make symbols_count_time faster Make symbols_count_time faster May 3, 2019
@ivan-nginx
Copy link
Member

@stevenjoezhang here is must exists tag BC because with this changes plugin must be update to the latest version.

@ivan-nginx ivan-nginx merged commit 5b33236 into theme-next:master May 3, 2019
@stevenjoezhang stevenjoezhang deleted the count branch May 3, 2019 09:12
jiangtj pushed a commit to jiangtj/hexo-theme-next that referenced this pull request May 6, 2019
@Maples7
Copy link
Contributor

Maples7 commented May 20, 2019

It seems this PR breaks words count even though after I update hexo-symbols-count-time to 0.6.0?
image

I update theme code to the newest of master (up to this commit: 7c24d10) locally with my own configurations exactly like here: https://github.com/Maples7/blog. By the way, I use theme_config field in site config file to do settings.

GitHub
Blog of Maples7 . Contribute to Maples7/blog development by creating an account on GitHub.

@ivan-nginx
Copy link
Member

Question to @stevenjoezhang.

@ivan-nginx
Copy link
Member

@Maples7, question is solved?

@Maples7
Copy link
Contributor

Maples7 commented May 23, 2019

I think so! With [email protected] and newest master code up to ec648f4.

@Maples7
Copy link
Contributor

Maples7 commented May 23, 2019

Thank you guys very much!

invkrh added a commit to invkrh/hexo-theme-next that referenced this pull request Jun 16, 2019
* tag 'v7.1.2':
  Release v7.1.2
  Quotes in Release Drafter for around possible bugs
  Add Icons in Release Drafter
  Expressions and translations in CONTRIBUTING.md (theme-next#885)
  Fix Release Drafter template
  `External Change` label added
  Change the internal path of quicklink (theme-next#883)
  Improve Docs section in PR template
  Force HTTPS of `google-analytics.swig`. Again. (theme-next#881)
  Update Facebook Graph API to v3.3 (theme-next#876)
  Fix a few typo errors in docs (theme-next#864)
  Changed Telegram group link to Chinese
  Fix Github gist bug (theme-next#861)
  Update symbols_count_time (theme-next#862)
  Release v7.1.1
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants