Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS bug in Codeblock if string longer than viewport #803

Merged
merged 6 commits into from
Apr 4, 2019
Merged

CSS bug in Codeblock if string longer than viewport #803

merged 6 commits into from
Apr 4, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #761

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor Author

Another feature request about code block: iissnan/hexo-theme-next#2001

@ivan-nginx ivan-nginx added the CSS label Apr 3, 2019
@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx Updated. You can test with this:

```
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
```

```yaml
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
```

{% codeblock yaml config.yml %}
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
{% endcodeblock %}


```
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
```

```yaml
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
```

{% codeblock yaml config.yml %}
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Natus facilis quae quo architecto incidunt fugiat sapiente, assumenda labore, voluptate consequatur, nam cumque repellat hic vero odit. Quibusdam ipsa dicta at.
{% endcodeblock %}

@ivan-nginx ivan-nginx added this to the v7.2.0 milestone Apr 3, 2019
@ivan-nginx ivan-nginx modified the milestone: v7.2.0 Apr 3, 2019
@ivan-nginx ivan-nginx changed the title Fix CSS bug in Codeblock if string longer than viewport CSS bug in Codeblock if string longer than viewport Apr 3, 2019
@ivan-nginx ivan-nginx modified the milestone: v7.2.0 Apr 3, 2019
@ivan-nginx ivan-nginx merged commit 205bd16 into theme-next:master Apr 4, 2019
@stevenjoezhang stevenjoezhang deleted the fig branch April 4, 2019 01:33
invkrh added a commit to invkrh/hexo-theme-next that referenced this pull request Apr 13, 2019
@invkrh
Merge remote-tracking branch 'upstream/master'
77c47c9 
* upstream/master: (65 commits)
  fix theme-next#815 (theme-next#828)
  Update IPC url (theme-next#827)
  List items appeared correctly in mobile with `mobile_layout_economy` option (theme-next#817)
  New translations en.yml (French) (theme-next#819)
  Improve French translation (theme-next#818)
  Fix wrong sidebar style on mobile (theme-next#808)
  Delete inactive reviewer
  New translations en.yml (Spanish) (theme-next#806)
  CSS bug in Codeblock if string longer than viewport (theme-next#803)
  Commented Project
  Temporairly turn off Project checking
  Disable Projects compairing
  Fix `vv` for Release Drafter
  Spanish translation (theme-next#801)
  Optimize images (theme-next#802)
  Release v7.1.0
  Change Algolia link in config
  Reduce reviewers for remove scrolling in PR's (theme-next#797)
  Disable add Assigners in Auto Assign bot (theme-next#795)
  Bug Fix: PDF won't display in particular situation (theme-next#794)
  ...
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang @ivan-nginx
CSS bug in Codeblock if string longer than viewport (theme-next#803)
36c971d 
* fix theme-next#761

* Fixed right marign during refresh

* Backed highlight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

@1v9 1v9 Awaiting requested review from 1v9

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🐞 Bug Fix CSS
Projects
None yet
Milestone
v7.1.1
Development

Successfully merging this pull request may close these issues.

CSS bug in Codeblock if string longer than viewport
2 participants
@stevenjoezhang @ivan-nginx