Skip to content

Sidebar button style on Pisces and Gemini #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2019
Merged

Sidebar button style on Pisces and Gemini #735

merged 2 commits into from
Mar 25, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #734

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang requested review from ivan-nginx and 1v9 and removed request for ivan-nginx March 25, 2019 07:06
ivan-nginx
ivan-nginx reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To many rewrites (important). In ideal important parameters must not exists. Try to do better, it is possible, i think.

@stevenjoezhang
Copy link
Contributor Author

Git doesn't recognize the changes correctly... However this PR does solve the problem and not change anything else...

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 25, 2019
@stevenjoezhang stevenjoezhang merged commit 9876b88 into theme-next:master Mar 25, 2019
@stevenjoezhang stevenjoezhang deleted the css branch March 25, 2019 16:45
@ivan-nginx ivan-nginx mentioned this pull request Mar 25, 2019
Closed
@liolok liolok changed the title Fix #734: Sidebar button style on Pisces and Gemini Sidebar button style on Pisces and Gemini Mar 31, 2019
@weekly-digest weekly-digest bot mentioned this pull request Mar 31, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Fix theme-next#734: Sidebar button style on Pisces and Gemini (theme-…
1cdaae0 
…next#735)
whyliam pushed a commit to whyliam/hexo-theme-next that referenced this pull request Apr 19, 2025
@renovate
Update dependency stylelint to v16 (theme-next#735)
3f4e57d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

@1v9 1v9 Awaiting requested review from 1v9

Assignees
No one assigned
Labels
🐞 Bug Fix CSS
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

Some refactoring brake RSS style?
2 participants
@stevenjoezhang @ivan-nginx