Remove qihu_site_verification and move some options to SEO Settings
#706
Conversation
| {% if theme.fancybox %} | ||
| {% set fancybox_css_uri = url_for(theme.vendors._internal + '/fancybox/source/jquery.fancybox.css?v=2.1.5') %} | ||
| {% set fancybox_css_uri = url_for(theme.vendors._internal + '/fancybox/source/jquery.fancybox.css') %} |
There was a problem hiding this comment.
Version need for auto-updating cache.
For example:
- If FB will
v3.5.6and after update & redeploying willv3.5.7and - If CSS of this versions have difference and
- If on server-side will defined long-life cache
Thenv3.5.7will be loaded as oldv3.5.6with some interface bugs. Yes, developers know what need simply refresh browser's cache, but simple users (your blog visitors) don't know it.
I suggest define latest FB v3. In our case for now it v3.5.7. And even if we want using old v2.1.5, there will no update for this version and all will be working fine.
There was a problem hiding this comment.
fancybox2 is no longer maintained, and we didn't update fancybox3 in the past whole year (even it's updated from 3.2.5 to 3.5.7, but no one from NexT updated it). So I believe removing the version number will not affect anything.
There was a problem hiding this comment.
Soon was 3.5.6 version. Then u update to 3.5.7. Tomorrow can be 3.5.8, etc. I believe version number must present here for maximum round all possible bugs in the future – this is argument. Your arguments?
There was a problem hiding this comment.
But the truth is that the cycle of updating our plugins is significantly longer than the usual cache time of servers and browsers... However, if you can find a beautiful solution to deal with this problem (version numbers for both fancybox2 and 3), I will support it.
Another problem is that the users may not update the theme-next-fancybox in time, this will also cause version number issues...
There was a problem hiding this comment.
Another problem is that the users may not update the theme-next-fancybox in time, this will also cause version number issues...
Well, this is argument, agree. So, if u already know solution about cache refresh without modifying current file, awaiting for it.
But version number will just increase and cache will auto-refresh anyway... Another thing is: if user will update FB module after updating NexT, yes. Version & Cache will not refresh.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?