Skip to content

Make site-state-item centered using flex #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2019
Merged

Make site-state-item centered using flex #700

merged 2 commits into from
Mar 17, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 16, 2019 •
edited by ivan-nginx
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A
屏幕快照 2019-03-17 上午2 14 52
屏幕快照 2019-03-17 上午2 14 57

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A
    屏幕快照 2019-03-17 上午2 34 41

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

ivan-nginx
ivan-nginx approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is good! Need to moved from floated elements on flex. But flex must be in v7+ only, for v6.x no need adapt flex.

Also, this is looks like Optimization (Refactoring), not like Bugfix.

@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 16, 2019
@stevenjoezhang
Copy link
Contributor Author

屏幕快照 2019-03-17 上午8 45 09
Yes, this should be a v7+ feature, some ancient browsers (about 4%) doesn't support display: flex

@stevenjoezhang stevenjoezhang merged commit ce75c7e into theme-next:master Mar 17, 2019
@stevenjoezhang stevenjoezhang deleted the state branch March 17, 2019 00:48
@ivan-nginx ivan-nginx changed the title Make site-state-item centered using flex Maked site-state-item centered using flex Mar 19, 2019
@liolok liolok changed the title Maked site-state-item centered using flex Make site-state-item centered using flex Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Make site-state-item centered using flex (theme-next#700)
bc31368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 left review comments

@ivan-nginx ivan-nginx ivan-nginx approved these changes

Assignees
No one assigned
Labels
CSS 🛠 Improvement
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @ivan-nginx @1v9