Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff code hightlight problem #665

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Diff code hightlight problem #665

merged 1 commit into from
Mar 8, 2019

Conversation

zq1997
Copy link
Contributor

@zq1997 zq1997 commented Mar 8, 2019

+ green background for added line
- red for deleted line
but old css style use wrong colors

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

for diff code block, currently it make wrong background color for added/deleted line for some hight theme.

Issue resolved: yes

What is the new behavior?

exchange the color variable value and problem sovled.

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

just a small change for css style

Does this PR introduce a breaking change?

  • Yes.
  • No.

```diff
+ green background for added line
- red for deleted line
but old css style use wrong colors
```
@1v9 1v9 merged commit 9810af2 into theme-next:master Mar 8, 2019
@ivan-nginx ivan-nginx changed the title fix diff code hightlight problem Fixed diff code hightlight problem Mar 8, 2019
@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 8, 2019
@liolok liolok changed the title Fixed diff code hightlight problem Diff code hightlight problem Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
```diff
+ green background for added line
- red for deleted line
but old css style use wrong colors
```
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants