Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pdf tag #659

Merged
merged 2 commits into from
Mar 6, 2019
Merged

New pdf tag #659

merged 2 commits into from
Mar 6, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 6, 2019

Breaking Change:

CREATED new pdf tag
MOVED pdf settings from Third Party Services Settings to Tags Settings in _config.yml
DOCS https://theme-next.org/docs/tag-plugins/pdf/

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@theme-next theme-next deleted a comment Mar 6, 2019
@theme-next theme-next deleted a comment Mar 6, 2019
@1v9 1v9 removed their request for review March 6, 2019 10:43
@1v9
Copy link
Member

1v9 commented Mar 6, 2019

never use pdf, but the logic (instead of per_page) is same as mermaid.

@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 6, 2019
@stevenjoezhang stevenjoezhang merged commit 1312c49 into theme-next:master Mar 6, 2019
@stevenjoezhang stevenjoezhang deleted the pdf branch March 6, 2019 16:42
@ivan-nginx ivan-nginx changed the title Refactoring pdf.js Refactoring pdf.js & Added pdf tag Mar 6, 2019
@liolok liolok changed the title Refactoring pdf.js & Added pdf tag Refactor pdf.js & add pdf tag Mar 31, 2019
@liolok liolok changed the title Refactor pdf.js & add pdf tag New pdf tag Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants