Usage of back2top button
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangtj
reviewed
Mar 6, 2019
| @@ -5,7 +5,7 @@ | |||
| @import "pagination"; | |||
| @import "comments"; | |||
| @import "tag-cloud"; | |||
| @import hexo-config('sidebar.b2t') ? "back-to-top-sidebar" : "back-to-top"; | |||
| @import hexo-config('back2top.sidebar') ? "back-to-top-sidebar" : "back-to-top"; | |||
There was a problem hiding this comment.
Add if hexo-config('back2top.enable')?
@import hexo-config('back2top.sidebar') ? "back-to-top-sidebar" : "back-to-top" if hexo-config('back2top.enable');
|
|
|
Should work fine now.. |
jiangtj
requested changes
Mar 6, 2019
|
Ahh... I forgot something ... Updated again |
|
|
jiangtj
approved these changes
Mar 6, 2019
|
@stevenjoezhang see how to add readme when breaking changes exists. Also, don't forgot to update docs on website. |
|
@ivan-nginx I know, docs have already been added |
|
@stevenjoezhang I mean – don't forget to set checkbox if docs already added. |
|
Sorry, I'll check again |
11 tasks
ivan-nginx
reviewed
Apr 4, 2019
| @@ -107,6 +107,8 @@ | |||
| scheme: '{{ theme.scheme }}', | |||
| version: '{{ version }}', | |||
| sidebar: {{ theme.sidebar | json_encode }}, | |||
| back2top: {{ theme.back2top.enable }}, | |||
There was a problem hiding this comment.
Need to refactor this under json, no need both back2top and back2top_sidebar parameters.
There was a problem hiding this comment.
Yes, it's a good idea. You can do it.
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?