Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force language options to Gitalk comment system #653

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Force language options to Gitalk comment system #653

merged 1 commit into from
Mar 4, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Mar 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #651

What is the new behavior?

  • Language can be foced.
  • leave language empty, same as before
    zh-CN.jpg
  • Add es-ES
    es-ES.jpg

How to use?

In NexT _config.yml:

gitalk:
  enable: false
  github_id:  # Github repo owner
  repo:  # Repository name to store issues
  client_id:  # Github Application Client ID
  client_secret:  # Github Application Client Secret
  admin_user:  # GitHub repo owner and collaborators, only these guys can initialize github issues
  distraction_free_mode: true # Facebook-like distraction free mode
  # Gitalk's display language depends on user's browser or system environment
  # If you want everyone visiting your site to see a uniform language, you can set a force language value
  # Available value: en, es-ES, fr, ru, zh-CN, zh-TW
+ language:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 requested review from maple3142, stevenjoezhang, ivan-nginx and sli1989 and removed request for maple3142 March 4, 2019 13:34
@1v9 1v9 merged commit b247e3f into theme-next:master Mar 4, 2019
@1v9 1v9 deleted the gitalk branch March 4, 2019 14:11
1v9 added a commit to theme-next/theme-next.org that referenced this pull request Mar 4, 2019
@ivan-nginx
Copy link
Member

@1v9, @stevenjoezhang don't forget to set labels.

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 4, 2019
@liolok liolok changed the title Feat: Add force language to Gitalk Force language options to Gitalk comment system Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitalk语言无法设置为英语
3 participants