New tag video & warn when use exturl or extlink
#652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-nginx
reviewed
Mar 4, 2019
| @import "note" if hexo-config('note.style') == 'simple' || hexo-config('note.style') == 'flat'; | ||
| @import "note-modern" if hexo-config('note.style') == 'modern'; | ||
| @import "label" if hexo-config('label'); |
There was a problem hiding this comment.
It seems need to remove label option from config.
There was a problem hiding this comment.
Yes, it's related to theme-next/theme-next.org#18, and won't cause any side effect. The label option only appears once. Considering that we didn't add options for most tags (e.g. button, center-quote, full-image etc.), it would be better to remove it.
There was a problem hiding this comment.
Updated, looks fine now
There was a problem hiding this comment.
@ivan-nginx Able to merge now?
ivan-nginx
reviewed
Mar 6, 2019
| @@ -103,7 +103,7 @@ | |||
| {% block script_extra %}{% endblock %} | |||
|
|
|||
| {% include '_scripts/next-boot.swig' %} | |||
| {% include '_third-party/quicklink/index.swig' %} | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, it's fine
ivan-nginx
approved these changes
Mar 6, 2019
liolok
changed the title
exturl tag & Add video tag & Code style updateexturl tag & add video tag & update code style
liolok
changed the title
exturl tag & add video tag & update code stylevideo and warn when use exturl or extlink
ivan-nginx
changed the title
video and warn when use exturl or extlinkvideo & warn when use exturl or extlink
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?