Skip to content

External links didn't get replaced in index page & «DeprecationWarning: Buffer()» in nodejs 10.x #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2019
Merged

External links didn't get replaced in index page & «DeprecationWarning: Buffer()» in nodejs 10.x #599

merged 2 commits into from
Feb 21, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Feb 4, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved #594

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Feb 4, 2019
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Feb 4, 2019 •
edited
Loading

Why using Buffer.from() instead of new Buffer(): https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/

@theme-next theme-next deleted a comment Feb 4, 2019
@theme-next theme-next deleted a comment Feb 4, 2019
@theme-next theme-next deleted a comment Feb 4, 2019
@theme-next theme-next deleted a comment Feb 11, 2019
@theme-next theme-next deleted a comment Feb 11, 2019
@theme-next theme-next deleted a comment Feb 11, 2019
@theme-next theme-next deleted a comment Feb 15, 2019
@theme-next theme-next deleted a comment Feb 15, 2019
@theme-next theme-next deleted a comment Feb 15, 2019
@theme-next theme-next deleted a comment Feb 15, 2019
@theme-next theme-next deleted a comment Feb 15, 2019
@theme-next theme-next deleted a comment Feb 15, 2019
@theme-next theme-next deleted a comment from jiangtj Feb 15, 2019
@theme-next theme-next deleted a comment from stevenjoezhang Feb 15, 2019
@theme-next theme-next deleted a comment from jiangtj Feb 15, 2019
@stevenjoezhang stevenjoezhang merged commit b8a1fcc into theme-next:master Feb 21, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Feb 21, 2019
Closed
11 tasks
@stevenjoezhang stevenjoezhang deleted the exturl branch February 21, 2019 03:50
@ivan-nginx
Copy link
Member

ivan-nginx commented Feb 23, 2019 •
edited
Loading

What is better? We can redefine this option in Codacy.

From https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/

The Buffer() and new Buffer() constructors are not recommended for use due to security and usability concerns. Please use the new Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() construction methods instead.

@ivan-nginx ivan-nginx mentioned this pull request Mar 19, 2019
Closed
@ivan-nginx ivan-nginx changed the title Fix #594: External links didn't get replaced in index page External links didn't get replaced in index page & «DeprecationWarning: Buffer()» in nodejs 10.x Mar 19, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Fix theme-next#594: External links didn't get replaced in index page (t…
a3dec15 
…heme-next#599)

* Fix theme-next#594

* Use `Buffer.from()` instead of `new Buffer()`
wens07 pushed a commit to wens07/hexo-theme-next that referenced this pull request May 8, 2023
@renovate
Update dependency eslint to v8.31.0 (theme-next#599)
6dc1e94 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangtj jiangtj Awaiting requested review from jiangtj

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

Assignees
No one assigned
Labels
🐞 Bug Fix
Projects
None yet
Milestone
v7.0.1
Development

Successfully merging this pull request may close these issues.

In index page, external links didn't get replaced with spanned links.
2 participants
@stevenjoezhang @ivan-nginx