Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comment count and reward QR #595

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Conversation

Lruihao
Copy link
Contributor

@Lruihao Lruihao commented Jan 31, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved N/A

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang merged commit 0926ec4 into theme-next:master Feb 4, 2019
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Feb 4, 2019
@liolok
Copy link
Member

liolok commented Mar 1, 2019

Please write pull request in a better style, and I suppose this pr should be written as two different one.

@Lruihao
Copy link
Contributor Author

Lruihao commented Mar 1, 2019

ok,i will pr again as two different.

@liolok
Copy link
Member

liolok commented Mar 1, 2019

@Lruihao Thanks for your work. Please write more details and refer to other PRs for style.

@liolok
Copy link
Member

liolok commented Mar 1, 2019

ok,i will pr again as two different.

@Lruihao I edited title for this time, could you please add details for others to understand?

@liolok liolok changed the title two bugs . The one is the tip of comments-number,the anther is that plugin hexo-all-minifier changs the 'QR' to ' qr' so that the reward button not to ues. Fix comment count and reward QR Mar 1, 2019
@Lruihao
Copy link
Contributor Author

Lruihao commented Mar 1, 2019

sorry,my english is so poor!haha,and in fact,my commit just fixs two simple bugs that one makes comment count friendly,and other one fixs the disable reward buttom bug cause of the plugin hexo-all-minifier.

@liolok
Copy link
Member

liolok commented Mar 1, 2019

@Lruihao I'm just a newbie here to make monthly release. I haven't contributed any code to now, so I'm appreciate for your work. But, it's also necessary to fill the descriptions like both current behavior and new behavior, text and screenshots, to make other people know about what changes this pull request make. If you are not familiar with these stuff, you could go check other PRs, most of them are clear.

@ivan-nginx ivan-nginx changed the title Fix comment count and reward QR Fixed comment count and reward QR Mar 1, 2019
@stevenjoezhang
Copy link
Contributor

Element id QR has been renamed to qr. See 8cc79e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants