Skip to content

Fix #495, #473 and #231 url_for() misuse #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2018
Merged

Fix #495, #473 and #231 url_for() misuse #496

merged 1 commit into from
Dec 10, 2018

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): #495, #473 and #231

Hexo generates wrong post link when website is in a subdirectory,

because url_for() executed twice on post.link

2018-12-08 7 02 47

2018-12-08 7 03 04

What is the new behavior?

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang merged commit 0183703 into theme-next:master Dec 10, 2018
@ivan-nginx ivan-nginx added this to the v6.7.0 milestone Dec 10, 2018
@ivan-nginx ivan-nginx mentioned this pull request Dec 10, 2018
Merged
15 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Dec 10, 2018
Closed
11 tasks
@stevenjoezhang stevenjoezhang changed the title Fix #495, #473 and #231 Fix #495, #473 and #231 url_for() misuse Dec 31, 2018
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
bug fix (theme-next#496)
262a3ed
wens07 pushed a commit to wens07/hexo-theme-next that referenced this pull request May 8, 2023
@leirock
Update avilability of pjax & local_search in vendors (theme-next#496)
aae3ab8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

Assignees
No one assigned
Labels
🐞 Bug Fix
Projects
None yet
Milestone
v6.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @ivan-nginx