Skip to content

Fix #399 and #394 fancybox misuse #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Fix #399 and #394 fancybox misuse #468

merged 2 commits into from
Nov 7, 2018

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Nov 7, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

[![](/images/icon.gif)](https://github.com)

When you click the image, fancybox will load, then report an error because https://github.com is not an image.
Issue Number(s): #399 and #394

What is the new behavior?

Prevent the img in an anchor from being wrapped as fancybox.
When you click the image, https://github.com will open in a new tab.

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@Raincal Raincal merged commit c68bf23 into theme-next:master Nov 7, 2018
@Raincal Raincal added this to the v6.6.0 milestone Nov 7, 2018
@stevenjoezhang stevenjoezhang deleted the fancybox branch November 7, 2018 12:02
Ahaochan added a commit to Ahaochan/Ahaochan.github.io that referenced this pull request Nov 8, 2018
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Nov 18, 2018

@ivan-nginx In source/js/src/utils.js line 10, should not('[hidden]') be not(':hidden')?

@stevenjoezhang stevenjoezhang changed the title Fix #399 and #394 Fix #399 and #394 fancybox misuse Dec 31, 2018
Ahaochan added a commit to Ahaochan/Ahaochan.github.io that referenced this pull request Mar 16, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants