-
Notifications
You must be signed in to change notification settings - Fork 2k
Add enable option for read_more_btn #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default value of read_more_btn
should be true
for the consistence.
_config.yml
Outdated
@@ -264,6 +264,7 @@ save_scroll: false | |||
|
|||
# Automatically excerpt description in homepage as preamble text. | |||
excerpt_description: true | |||
read_more_btn: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it's fine. sorry for the mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to place after the auto_excerpt
like here
Line 274 in 64b0a8f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did as you mentioned above in the first commit.
However, I find that read_more_btn
is not only related to auto_excerpt
, but also post.description
, post.excerpt
. So I move it outside in the second commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean excerpt_description
and auto_excerpt
are related to more
. so place after the section of auto_excerpt
without indents. not meaning of your first commit.
first excerpt description setting ,and then button setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Automatically excerpt description in homepage as preamble text.
excerpt_description: true
# Automatically Excerpt. Not recommend.
# Please use <!-- more --> in the post to control excerpt accurately.
auto_excerpt:
enable: false
length: 150
# Read more button, which works only in Excerpt Mode
read_more_btn: true
what about this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it is what i mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which works only in Excerpt Mode
seems no need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If true, the read more button would be displayed in excerpt section
I prefer like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your suggestion
* optional: disable read_more_btn * Feat: Add enable option for read_more_btn * update * add comments
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Disable the readmore_button can make the blog more concise. Like the following case
How to use?
In Next
_config.yml
:-->