-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix an issue about the categories/tags count. #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue about the categories/tags count. #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good, yeah. This bug is so old what i forget about it. GJ.
P.S. For Archives mb need to do the same thing. |
🎉 The Archives seems ok, |
Good Fixed ! |
Good Fixed ! |
Fix an issue about the categories/tags count.
Superseded by hexojs/hexo#3624 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I have an article in the _drafts that contains 2 tags: compression, pngquant.
But the tags page shows the number with all articles including the draft ones.
What is the new behavior?
This commit changes the variable from reading
site.tags.length
tosite.tags.filter(t => t.length).length
, to make sure the result number will be right. (Also changes the categories)Does this PR introduce a breaking change?