Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-comments #1048

Merged
merged 40 commits into from
Aug 7, 2019
Merged

Add multi-comments #1048

merged 40 commits into from
Aug 7, 2019

Conversation

jiangtj
Copy link
Member

@jiangtj jiangtj commented Aug 3, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Not support multi-comments.

Issue resolved: iissnan/hexo-theme-next#1604

What is the new behavior?

Add multi-comments support.

How to use?

In NexT _config.yml:

# Multiple Comment System Support
comments:
  # Available values: tabs | buttons
  style: tabs
  # Choose a comment system to be displayed by default
  # Available values: changyan | disqus | disqusjs | facebook_comments_plugin | gitalk | livere | valine | vkontakte
  active:
  # Setting `true` means remembering the comment system selected by the visitor
  storage: true
  # Modify icons and texts for any style, here are some examples
  nav:
    #disqus: disqus
    #facebook_comments_plugin: <i class="fa fa-facebook-official" aria-hidden="true"></i> facebook
    #gitalk: Load Gitalk

The nav configuration is updated at #1136. If you are using the release version, please check the #1136.

@liolok publish release use the configuration in #1136

Does this PR introduce a breaking change?

  • Yes.
  • No.

@theme-next theme-next deleted a comment Aug 3, 2019
@jiangtj
Copy link
Member Author

jiangtj commented Aug 3, 2019

Disqus and disqusjs cannot be enabled at the same time

@1v9
Copy link
Member

1v9 commented Aug 3, 2019

No problem, they are same 🐱‍👤

@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@jiangtj
Copy link
Member Author

jiangtj commented Aug 3, 2019

image

post meta ....

@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@jiangtj jiangtj marked this pull request as ready for review August 3, 2019 08:31
@jiangtj jiangtj added this to the v7.4.0 milestone Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment Aug 3, 2019
@theme-next theme-next deleted a comment from jiangtj Aug 7, 2019
@ivan-nginx
Copy link
Member

Docs on website needed?

@jiangtj
Copy link
Member Author

jiangtj commented Aug 7, 2019

Docs on website needed?

Need

@jiangtj jiangtj mentioned this pull request Aug 7, 2019
Merged
@jiangtj jiangtj merged commit 541e477 into master Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the multi-comments branch August 7, 2019 09:33
@sli1989
Copy link
Collaborator

sli1989 commented Aug 16, 2019

seems there is a spare pace after the number of the comment?

@jiangtj
Copy link
Member Author

jiangtj commented Aug 16, 2019

seems there is a spare pace after the number of the comment?

A spare pace? where? Can you cut a picture?

@sli1989
Copy link
Collaborator

sli1989 commented Aug 16, 2019

image

@jiangtj
Copy link
Member Author

jiangtj commented Aug 16, 2019

image
Not a space, the same width is OK？

@sli1989
Copy link
Collaborator

sli1989 commented Aug 16, 2019

u see? the space after 1 comment & 0 is differrent.

@jiangtj
Copy link
Member Author

jiangtj commented Aug 16, 2019 •
edited
Loading

image
This space? 😂 This problem existed before, and there are some space between </span></a>

@jiangtj jiangtj mentioned this pull request Aug 16, 2019
Merged
15 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@jiangtj
Add multi-comments (theme-next#1048)
26cfb3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx left review comments

@1v9 1v9 1v9 approved these changes

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🌟 New Feature
Projects
None yet
Milestone
v7.4.0
5 participants
@jiangtj @1v9 @sli1989 @ivan-nginx @stevenjoezhang