Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when theme.font has empty family value #1015

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Fix a bug when theme.font has empty family value #1015

merged 1 commit into from
Jul 26, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Jul 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

When theme.font has empty family value, the font list will contain empty value, thus resulting in the final string format being incorrect, and there are several situations.

What is the new behavior?

Users could live font family value empty.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 added this to the v7.3.0 milestone Jul 26, 2019
@1v9 1v9 requested a review from jiangtj July 26, 2019 08:33
@1v9 1v9 merged commit 215dfb6 into master Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the ext-font branch July 26, 2019 08:42
@1v9 1v9 added the 🌀 Fonts label Aug 13, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant