cli: don't error if the user folder doesn't exist #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user folder gets created on demand, thelounge list should not fail if the folder doesn't exist. This just means that no users are present, so report that instead.
brunnre8
commented
Mar 8, 2022
| log.info( | ||
| `There are currently no users. Create one with ${colors.bold( | ||
| "thelounge add <name>" | ||
| )}.` | ||
| ); | ||
| return; |
There was a problem hiding this comment.
I'm a fan of return early, keep the happy path to the left.
If you disagree heavily please tell me and I'll adapt my style.
There was a problem hiding this comment.
I think either way is fine. Code style seems like a fairly low stakes thing in an OSS code case with an auto formatter too.
itsjohncs
approved these changes
Mar 9, 2022
itsjohncs
added
the
Type: Bug
brunnre8
added
the
Status: release-after-next
MaxLeiter
removed
the
Status: release-after-next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user folder gets created on demand, thelounge list should not
fail if the folder doesn't exist.
This just means that no users are present, so report that instead.