docs(skill): codify merge-resolution rules and clean-mergeable-PR requirement#100
Merged
Conversation
…uirement Dispatched agents had no guidance on keeping a branch mergeable or resolving divergence with main — the #90 merge had to be hand-driven. Codify it: - implementing-github-issues: new "Keeping the branch mergeable into main" section — enable `git rerere` at workstream start, rebase by default, escape to a single merge commit when main deeply re-architected the same code, and the new-work-as-base resolution heuristic; always re-verify after resolving. Add a clean-mergeable core principle, a Phase 10c mergeability check before `gh pr ready`, red-flag rows, quick-reference rows, and a middle-dispatch delta (no human babysits the rebase headless). - CLAUDE.md: expand the rebase note with rerere + the merge escape hatch, and add a clean-mergeable-before-ready bullet to the PR workflow. - Re-sync the bootstrap-assets skills mirror (byte-identical with canonical).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request updates contributor guidelines and autonomous skill documentation to enforce that PR branches remain cleanly mergeable into ChangesMergeability Workflow Requirements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispatched agents had no codified guidance on keeping a branch mergeable or resolving divergence with
main— the #90 Phase 5 merge had to be hand-driven. This folds those rules into the skill agents actually read, plus the contributor guide.What changed
implementing-github-issuesskill (canonical + bootstrap-assets mirror, byte-identical):git rerereat workstream start (resolutions replay instead of being re-earned), rebase by default, escape to a singlegit mergewhenmaindeeply re-architected the same code a per-commit rebase keeps re-conflicting on, the new-work-as-base resolution heuristic, and always re-verify after resolving.gh pr view --json mergeable) beforegh pr ready, two red-flag rows, three quick-reference rows, and a middle-dispatch delta (headless, no human babysits the rebase).CLAUDE.md: expanded the "we rebase, we don't squash" note withrerere+ the merge escape hatch, and added a "PR must be cleanly mergeable before ready" bullet to the PR workflow.Why these changes
The merge strategy is a real judgment call (rebase for clean history vs. a single merge for deep interleave) with a load-bearing heuristic (new-work-as-base) that an agent won't infer on its own.
rererespecifically turns a hard-won resolution into a replayable one — high leverage during multi-commit rebases. Source: the #90 merge experience.Verification
bun scripts/sync-skills.ts→ mirror re-synced; canonical and bootstrap-assets copiesdiff-identical.skills: bootstrap-assets mirror is in sync.How to review
Read the new "Keeping the branch mergeable into main" section in
packages/skills/implementing-github-issues/SKILL.mdand the CLAUDE.md rebase note. Confirm the rebase-vs-merge decision rule and the new-work-as-base heuristic read clearly to a fresh agent.Out of scope
.claude//.codex/stamped skill copies are written bymm init; they pick up this content on next init/sync.Summary by CodeRabbit