[ty] Synthesize __setattr__ and __delattr__ for frozen dataclasses#2
Closed
thejchap wants to merge 2 commits intofeature/setattr-return-typefrom
Closed
[ty] Synthesize __setattr__ and __delattr__ for frozen dataclasses#2thejchap wants to merge 2 commits intofeature/setattr-return-typefrom
thejchap wants to merge 2 commits intofeature/setattr-return-typefrom
Conversation
## Summary This currently doesn't work because the benchmark changes the working directory. Also updates the process name to make it easier to compare two local ty binaries.
sharkdp
force-pushed
the
feature/setattr-return-type
branch
from
22620d5 to
4265911
Compare
thejchap
force-pushed
the
feature/setattr-return-type
branch
2 times, most recently
from
ee5be7e to
e504514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
astral-sh/ty#111
astral-sh#17974 (comment)
WIP
Test Plan
WIP