Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isolated_labels.py #368

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Update isolated_labels.py #368

merged 5 commits into from
Jan 27, 2023

Conversation

danielStrobl
Copy link
Collaborator

As mentioned in #367, the isolated label metrics do not compute what they should.
By calculating the individual silhouette scores and then taking the mean over only the cells of the cluster, this should be fixed.

@LuckyMD
Copy link
Collaborator

LuckyMD commented Jan 27, 2023

I guess you'll need to adapt the tests as well for this.

Copy link
Collaborator

@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this looks correct, if silhouette_samples gives you the silhouette score per cell. See comment above about adding tests.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #368 (3aa8303) into main (1be0daa) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   53.13%   53.13%           
=======================================
  Files          22       22           
  Lines        1848     1848           
=======================================
  Hits          982      982           
  Misses        866      866           
Flag Coverage Δ
unittests 53.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scib/metrics/isolated_labels.py 94.33% <100.00%> (ø)

@LuckyMD
Copy link
Collaborator

LuckyMD commented Jan 27, 2023

Please also adapt the perfect score test

@danielStrobl danielStrobl merged commit e96da39 into main Jan 27, 2023
@danielStrobl
Copy link
Collaborator Author

ah bit too fast

@LuckyMD
Copy link
Collaborator

LuckyMD commented Jan 27, 2023

@mumichae could you still review this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants