-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update isolated_labels.py #368
Conversation
I guess you'll need to adapt the tests as well for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually this looks correct, if silhouette_samples gives you the silhouette score per cell. See comment above about adding tests.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
=======================================
Coverage 53.13% 53.13%
=======================================
Files 22 22
Lines 1848 1848
=======================================
Hits 982 982
Misses 866 866
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please also adapt the perfect score test |
ah bit too fast |
@mumichae could you still review this please? |
As mentioned in #367, the isolated label metrics do not compute what they should.
By calculating the individual silhouette scores and then taking the mean over only the cells of the cluster, this should be fixed.