Fix LISI warning error #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumichae
commented
Apr 29, 2022
| for i in enumerate(chunk_ids): | ||
| for i, chunk_id in enumerate(chunk_ids): |
There was a problem hiding this comment.
Changed notation for better readability
mumichae
commented
Apr 29, 2022
| print(i[1] + " has not enough neighbors.") | ||
| simpson[i[0]] = 1 # np.nan #set nan for testing | ||
| print(f'Chunk {chunk_id} does not have enough neighbors. Skipping...') |
There was a problem hiding this comment.
Bugfix here. F-strings used to avoid type mismatch
mumichae
commented
Apr 29, 2022
mbuttner
approved these changes
Apr 29, 2022
| for i in enumerate(chunk_ids): | ||
| for i, chunk_id in enumerate(chunk_ids): |
| print(i[1] + " has not enough neighbors.") | ||
| simpson[i[0]] = 1 # np.nan #set nan for testing | ||
| print(f'Chunk {chunk_id} does not have enough neighbors. Skipping...') |
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning message if LISI encounters a case with too few neighbours throws an error.