-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #279
Documentation #279
Conversation
Afaik, default values are already included in the autodoc. Or do you want more specific explanations on which values to use? |
I didn't see any in the readthedocs link... |
Ah, I was looking at the parameter explanation. Okay,all good. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic! A few minor points, but I think it would be good to merge.
A few general minor things which would be nice, but could/ should be separate PRs:
- Type information + autodoc-typehints would be nice
- It would be great if you can installation instructions for setting up an isolated environment (probably conda), especially due to the mixed language dependencies
- Kinda related: wouldn't you need Seurat for
read_seurat
?
- Kinda related: wouldn't you need Seurat for
- I would strongly recommend turning on PR builds for docs: https://docs.readthedocs.io/en/stable/pull-requests.html
Co-authored-by: Isaac Virshup <[email protected]>
Update docstrings and create sphinx docs for readthedocs.
Rendered documentation: https://scib--279.org.readthedocs.build/en/279/ (from in github checks at the bottom of this page)