-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update highly_variable_genes.py #269
Conversation
Clean up hvg_overlap metric, remove commented out code, remove unused pre-storage of highly variable genes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have some more documnetation on the HVG computation and HVG overlap score. Could you add some docstrings?
About the code, it might be better to make it more readable, so anyone can understand what is being done. I added some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some naming could be improved, but fine.
This PR has been lying around for a while. @danielStrobl Could you please check if the code is correct? Then we should be able to merge |
looks good to me |
Clean up hvg_overlap metric, remove commented out code, remove unused pre-storage of highly variable genes