Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highly_variable_genes.py #269

Merged
merged 9 commits into from
Apr 13, 2022
Merged

Update highly_variable_genes.py #269

merged 9 commits into from
Apr 13, 2022

Conversation

danielStrobl
Copy link
Collaborator

Clean up hvg_overlap metric, remove commented out code, remove unused pre-storage of highly variable genes

mumichae and others added 3 commits September 27, 2021 15:54
Clean up hvg_overlap metric, remove commented out code, remove unused pre-storage of highly variable genes
Copy link
Collaborator

@mumichae mumichae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have some more documnetation on the HVG computation and HVG overlap score. Could you add some docstrings?

About the code, it might be better to make it more readable, so anyone can understand what is being done. I added some suggestions.

scIB/metrics/highly_variable_genes.py Outdated Show resolved Hide resolved
scIB/metrics/highly_variable_genes.py Outdated Show resolved Hide resolved
Base automatically changed from check_metrics to master September 28, 2021 09:24
Copy link
Collaborator

@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some naming could be improved, but fine.

@mumichae
Copy link
Collaborator

This PR has been lying around for a while. @danielStrobl Could you please check if the code is correct? Then we should be able to merge

@danielStrobl
Copy link
Collaborator Author

looks good to me

@mumichae mumichae merged commit aa21754 into main Apr 13, 2022
@mumichae mumichae deleted the hvg_overlap_cleanup branch April 13, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants