Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ottjax 0.4.6 Errors #688

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Fixing ottjax 0.4.6 Errors #688

merged 7 commits into from
Apr 30, 2024

Conversation

selmanozleyen
Copy link
Collaborator

@selmanozleyen selmanozleyen commented Apr 16, 2024

errors also faced in #677

@giovp
Copy link
Member

giovp commented Apr 30, 2024

  • resave the alignment and mapping pickle file to fix the regression test

@selmanozleyen selmanozleyen changed the title Fixing ottjax 0.4.6 test import error Fixing ottjax 0.4.6 Errors Apr 30, 2024
@giovp
Copy link
Member

giovp commented Apr 30, 2024

hi @selmanozleyen thank you, it looks good but could you please skip instead of modifying iterations for the other two that needs to be fixed? so we can keep track of them better, after that, it can be merged!

@selmanozleyen
Copy link
Collaborator Author

@giovp ok done

@giovp giovp merged commit 389e008 into main Apr 30, 2024
8 checks passed
@giovp giovp deleted the fix/test-import-solve branch April 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants