Llm search #1531

frankyhollywood · 2024-06-17T08:21:16Z

No description provided.

projects/mercury/src/llm/Conversation.styles.js

tgreenwood · 2024-06-17T10:46:55Z

projects/mercury/src/llm/FulltextAPI.js

+ * Search for resources based on name or description, given query as a simple text.
+ */
+class FulltextAPI {
+    remoteURL = '/api/aisearch/';


I would put 'const' here

tgreenwood · 2024-06-17T10:57:46Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+                        var conversation = new JSONObject();
+                        conversation.put("id", obj.getJSONObject("conversation").getString("conversationId"));
+                        conversation.put("topic", obj.getJSONObject("conversation").getJSONArray("messages").getJSONObject(0).getJSONObject("userInput").getString("input"));
+                        conversation.put("start", new LlmConversation().getStartTime(obj.getJSONObject("conversation").getString("startTime")));


Please, move all logic to another layer, 'service' not to mixup controller layer with logic and for easier logic testing.

Also, I would create instance of LlmConversation on the class instance creation instead of creating it on each request

tgreenwood · 2024-06-17T11:12:36Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+
+    @Override
+    protected void initApp() {
+        get("/newchat", "application/json", (req, res) -> {


I would think of the API in REST/HTTP API way:

use HTTP DELETE method for deletion

use HTTP POST method for any type of creation (with the GET '/newchat' we change the state, it is not even idempotent)

not to use verbs in the path, use proper HTTP methods

We could consider API like this:

GET /chat - get all conversations

POST /chat - current /newchat

GET /chat/{id} - current /history/:id NOTE: I did not gat the difference between '/history/:id' and '/conversation/:id', could you elaborate please?

POST /chat/{id}/query

DELETE /chat/{id}

There is one more in the code POST '/' - I don't get it, please elaborate too

tgreenwood · 2024-06-17T11:16:29Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+    }
+
+    private Object handleError(Request req, Exception e) {
+        log.error("Unexpected error in AiSearchApp: " + e.getMessage() + "\n\nrequest: " + req.body());


I wouldn't put class name in the log as the name may be changed, logger configuration is the right place for that

tgreenwood · 2024-06-17T11:19:13Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+                    + Math.abs(token.getPreferredUsername().hashCode());
+        }
+
+        throw new UnsupportedOperationException("User key not found in token");


UnsupportedOperationException is used to literally say that something is not supported, should be another, at least RuntimeException and a proper wrapper

tgreenwood · 2024-06-17T11:20:55Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+        return "{}";
+    }
+
+    private String getUserKey() {


I would suggest not to bring this method here not to violate single responsibility principle, rather it could be another method of RequestContext class

tgreenwood · 2024-06-17T11:22:27Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+                    try {
+                        return new String(Files.readAllBytes(path));
+                    } catch (Exception e) {
+                        return "{}";


looks like error handling missed here

tgreenwood · 2024-06-17T11:26:29Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+                    try {
+                        var obj = new JSONObject(c);
+                        var conversation = new JSONObject();
+                        conversation.put("id", obj.getJSONObject("conversation").getString("conversationId"));


I would suggest to use POJO classes as more Java way instead of manipulation over pure JSON, it would also mitigate appearance of potential errors

tgreenwood · 2024-06-17T11:27:35Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+                try (FileWriter writer = new FileWriter(file)) {
+                    writer.write(result.toString());
+                } catch (Exception e) {
+                    System.out.println("Error writing conversation history file: " + e.getMessage());


please use logger, not system output

also, check other places, there are 6 of them

ewelinagr · 2024-06-17T11:29:09Z

To me the whole AISearch API belongs in Pluto, not Saturn. It is mainly based on redirection, this is one of the reasons Pluto was introduced for. Also, we already have ExternalSearch logic, which is really similar to this and stays within Pluto. To me Saturn should be all about our internal storage, not redirecting to external services

tgreenwood · 2024-06-17T11:30:54Z

projects/saturn/src/main/java/io/fairspace/saturn/services/search/AiSearchApp.java

+    }
+
+    private Object handleError(Request req, Exception e) {
+        log.error("Unexpected error in AiSearchApp: " + e.getMessage() + "\n\nrequest: " + req.body());


hm, we don't let user know that something went wrong, let's re-though it and handle with proper http error code in the handler in BaseApp

tgreenwood · 2024-06-17T11:43:38Z

projects/saturn/build.gradle

+    implementation("org.json:json:20240303")
+
+    // LLM is customer specific. By default the jar will be a demo implementation, overwrite it with customer specific implementation
+    implementation files("libs/nl-hyve-fairspace-demo-v2.4.jar")


To be honest, I am still not happy with the approach :( We are adding not only the dependency version, but artifact itself too. So, it is pretty tough to change it, too tight coupling. Also, let me know if I am stupid, I am not getting how we can conditionally AskAI switch on and off.

tgreenwood · 2024-06-17T11:48:25Z

also I remember Ask AI is a POC (it also does not include any tests), but way are we adding it to the dev branch?

tgreenwood · 2024-06-17T11:53:29Z

To me the whole AISearch API belongs in Pluto, not Saturn. It is mainly based on redirection, this is one of the reasons Pluto was introduced for. Also, we already have ExternalSearch logic, which is really similar to this and stays within Pluto. To me Saturn should be all about our internal storage, not redirecting to external services

There is a bit of logic around managing the chats and chat history, not sure it would be correct to put business logic to the gateway layer. I still believe it should be a separate service, not a part of Pluto nor Saturn. It would also let us easily toggle the whole feature

ewelinagr · 2024-07-24T12:50:47Z

Could you also make the naming more consistent? Especially the clases are currently named from LLM search, Fulltext search, AI search to just "conversation". I also see references like "Article search". I would prefix everything "AI" or "Llm" and then decide on single name afterwards, preferably "AISearch...", since this is how the API endpoint is named now. Then instead of:

= llm
== Conversation.js
== FulltextAPI.js
== LlmSearchPage.js

you would have:

= ai
== AISearchPage.js
== AISearchAPI.js
== AISearchConversation.js or AISearchPanel.js

ewelinagr · 2024-07-24T13:04:48Z

projects/mercury/src/llm/Conversation.js

+            .then(() => setLoading(false))
+            .catch(() => {
+                handleHttpError('Connection error.');
+                handleSearchError('Fairspace article search is not available at the moment');


"Fairspace article search" - is this always articles? If so, we should make it more specific, otherwise we need more generic naming

ewelinagr · 2024-07-24T13:06:33Z

projects/mercury/src/llm/Conversation.js

+
+    const showArticle = articleId => {
+        if (articleId !== null && articleId.length > 0) {
+            LocalSearchAPI.lookupSearch(articleId, 'https://www.fns-cloud.eu/study').then(extractArticleIri);


I don't like hardcoded prefixes in the generic UI, this is a component that works in a really specific setup...

ewelinagr · 2024-07-24T13:07:06Z

projects/mercury/src/llm/Conversation.js

+        return (
+            <div>
+                {responseArticles && responseArticles.length > 0 && (
+                    <Typography variant="caption">Source studies:</Typography>


it assumes a model with "study" entities?

ewelinagr · 2024-07-24T13:08:36Z

projects/mercury/src/llm/Conversation.js

+import LinkedDataEntityPage from '../metadata/common/LinkedDataEntityPage';
+import {LocalSearchAPI} from '../search/SearchAPI';
+
+const Conversation = props => {


This huge class should be divided into smaller modules, currently it is hard to follow what happens here

ewelinagr and others added 22 commits June 3, 2024 13:09

Change main menu, header and footer.

ec76836

Add app styling improvements.

267b559

Add UI styling improvements.

260f0ae

Adjust paddings and text color.

1fe9597

Fix numeric facet slider tooltip.

4508756

Display placeholder value for slider tooltip in numeric facet.

e11d62b

rag search for Fairspace

59fb21a

restore config

07c608c

Gui improvements LLM pages

1073749

Add Conversation.js

6a8aa8b

Conversation.js replacement

6893a14

Layout change and chart with secret

6aa89cc

Add question to history section after clicking "new question" button

3f72264

Show sources for history conversations

53241c5

Option to delete history chats, updated jar file

7eaa3ab

Make llm search optional

17d6266

Update README with AI search information

3672d0b

Add contact link to README

80f72bf

Fixed main menu after rebase

cfb8f12

New button for Chat

19e23f9

Added dependency for json parsing

b537084

Small refactor

003f0f2

tgreenwood reviewed Jun 17, 2024

View reviewed changes

projects/mercury/src/llm/Conversation.styles.js Show resolved Hide resolved

tgreenwood reviewed Jun 17, 2024

View reviewed changes

Java code formatter

e11cea1

ewelinagr force-pushed the ui-redesign branch 2 times, most recently from 17c0530 to 4d81cb8 Compare July 18, 2024 14:25

Base automatically changed from ui-redesign to dev July 24, 2024 10:21

ewelinagr reviewed Jul 24, 2024

View reviewed changes

frankyhollywood closed this Aug 12, 2024

frankyhollywood deleted the llm-search-rebase branch August 12, 2024 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Llm search #1531

Llm search #1531

frankyhollywood commented Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

ewelinagr commented Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood Jun 17, 2024

tgreenwood commented Jun 17, 2024

tgreenwood commented Jun 17, 2024

ewelinagr commented Jul 24, 2024 •

edited

Loading

ewelinagr Jul 24, 2024

ewelinagr Jul 24, 2024

ewelinagr Jul 24, 2024

ewelinagr Jul 24, 2024 •

edited

Loading

Llm search #1531

Llm search #1531

Conversation

frankyhollywood commented Jun 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewelinagr commented Jun 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tgreenwood commented Jun 17, 2024

tgreenwood commented Jun 17, 2024

ewelinagr commented Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewelinagr Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

ewelinagr commented Jul 24, 2024 •

edited

Loading

ewelinagr Jul 24, 2024 •

edited

Loading