Remove code for special decoding of webdav response. #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodeHTMLEntities seems not to be needed and it introduces vulnerability: "DOM text reinterpreted as HTML" - CWE-79, CWE-116
tgreenwood
reviewed
Apr 24, 2024
| @@ -479,12 +472,6 @@ class FileAPI { | |||
| mapToFile = fileObject => { | |||
| const properties = {...fileObject, ...(fileObject.props || {})}; | |||
| delete properties.props; | |||
| Object.keys(properties).forEach(key => { | |||
| // The WebDAV client does not properly decode the XML response, | |||
There was a problem hiding this comment.
Let me be honest, I still don't understand this part of the code. Did you check the problem this piece of code solves? Don't we remove a fix of something?
There was a problem hiding this comment.
I mean I see your comment, I saw the ticket you created. Does this ticket cover the issue? How critical is it?
There was a problem hiding this comment.
That is the thing, it doesn't seem to be solving any problem. Maybe there was something in previous versions of webdav, but now with or without it makes no difference (I tried various properties, various special characters - still no difference if it is there or not)
There was a problem hiding this comment.
good, let's indeed remove it and see how it goes
tgreenwood
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
decodeHTMLEntitiesseems not to be needed and it introduces vulnerability: "DOM text reinterpreted as HTML" - CWE-79, CWE-116.There is an issue with special characters in external storages, but this function doesn't fix the problem (reported in FAIRSPC-62)