Skip to content

Commit

Permalink
comment fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
thescientist13 committed Nov 16, 2018
1 parent 91a0111 commit dcff70e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key
RUN echo 'deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main' | tee /etc/apt/sources.list.d/google-chrome.list
RUN apt-get update && apt-get install -y google-chrome-stable default-jre

# install NodeJS 8 LTS
# install NodeJS LTS
RUN curl -sL https://deb.nodesource.com/setup_10.x | bash -
RUN apt-get install -y nodejs

Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ To see an example of this container being used for CI with all these features, s
| [Yarn][] | 1.x | |
| [npm][] | 6.x | |
| [Chrome Headless][] | N / A | Host packages needed to run **Chrome** Headless |
| [Chromium][] | Stable | Host packages needed to run **Chrome** browser (in headless mode) |
| [Chrome][] | Stable | Host packages needed to run **Chrome** browser (in headless mode) |
| [JRE][] | 8 | Java Runtime Environment (needed by **Selenium**) |

[NodeJS]: https://nodejs.org/en/download/
[npm]: https://www.npmjs.com/
[Yarn]: https://yarnpkg.com/en/
[Chrome Headless]: https://developers.google.com/web/updates/2017/04/headless-chrome
[Chromium]: https://www.chromium.org/
[Chrome]: https://www.google.com/chrome/
[JRE]: http://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html

### Command Line tools
Expand Down Expand Up @@ -122,3 +122,4 @@ Below are the steps to publish a new release of the image, based on this [guide]
1. Check the image [exists](https://hub.docker.com/r/thegreenhouse/nodejs-dev/tags/) in Docker Hub
1. Create a git tag `git tag -a x.y.z -m "tagging x.y.z release"`
1. Push the tag `git push origin master --tags`
1. Create Release Notes

0 comments on commit dcff70e

Please sign in to comment.