Rewrite inline let to have lexical scope

[mmun]

EDIT: The syntax of {{let}} and {{#let}} has changed since this PR.

This PR reimplements inline let as an HTMLBars AST transform. There is no notion of inline let at runtime. It works by rewriting the let statements as nested blocks. For example,

<div>
  {{let a 1 b 2}}
  {{let a 11 b 12 c (add a b)}}
  {{a}} {{b}} {{c}}
  <div>
    {{let a 5}}
    {{a}} {{b}} {{c}}
  </div>
  {{let a (add a 10)}}
  {{a}} {{b}} {{c}}
</div>

is transformed to (excluding whitespace changes to make it easier to read):

<div>
  {{#let 1 2 as |a b|}}
    {{#let 11 12 (add a b) as |a b c|}}
      {{a}} {{b}} {{c}}
      <div>
        {{#let 5 as |a|}}
          {{a}} {{b}} {{c}}
        {{/let}}
      </div>
      {{#let (add a 10) as |a|}}
        {{a}} {{b}} {{c}}
      {{/let}}
    {{/let}}
  {{/let}}
</div>

Both templates generate the DOM

<div>
  11 12 3
  <div>
    5 12 3
  </div>
  21 12 3
</div>

[taras]

@mmun thank you!

Ember 1.13 test is failing. In the current test suite, we're not testing inline let in 1.13.

Should we exclude the AST transform from for Ember 1.13 or is it possible to make it work with 1.13?

[mmun]

Should be possible. :)

EDIT: Actually, it would be a pain to get it working in 1.13 so I disable the transform below 2.0.0.

[mmun]

I've changed the example in the PR message to demonstrate that bindings are created in parallel rather than series (E.g. the semantics are like LISP's let rather than let*).

[Robdel12]

This is pretty awesome 🎉

[cowboyd]

For < 2.0 users, shouldn't there be an else with a warning that inline usage is not allowed?

[mmun]

We can do that.

[fivetanley]

is this glimmer 2 compatible?

[cowboyd]

An excellent question, is there a way that we can test it?

[Robdel12]

emberjs/ember.js#14156 looks like we can build vs canary?

[cowboyd]

So looks like it's going to require some work to get it working on Glimmer. We can track it with #14, but I don't think it should hold this up getting merged.

[cowboyd]

I can't begin to express how happy this makes me. A truly lexical inline form is almost bringing tears to my eyes y'all. Not even joking. Thanks @mmun and @rwjblue making this happen.

[taras]

Absolutely, thanks guys so much for helping us make this work.

[mmun]

@cowboyd I have a follow up PR soon that adds the warning.