Make React a flexible peer dependency #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React is very finnicky about having more than one copy of the react code itself in a single app https://reactjs.org/warnings/invalid-hook-call-warning.html Having a hard dependency on React 17 means then that a local copy of React 17 will be installed in this package and that it will be incompatible with React 16 apps. This changes the dependency on react to a peer dependency, and furthermore allows it to work on react 16 versions that have hooks, and version 17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
React is very finicky about having more than one copy of the react code itself in a single app
https://reactjs.org/warnings/invalid-hook-call-warning.html
Having a hard dependency on React 17 means then that a local copy of React 17 will be installed in this package and that it will be incompatible with React 16 apps.
Approach
This changes the dependency on react to a peer dependency, and furthermore allows it to work on react 16 versions that have hooks, and version 17.