Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that foreman_scap_client is included in client repo #2212

Merged

Conversation

aneta-petrova
Copy link
Member

https://community.theforeman.org/t/unable-to-install-foreman-scap-client/42039 reports an issue in the foreman_scap_client manual:

It is important to make sure foreman_scap_client package is available to your client system. Foreman plugins repo can be optionally enabled using the appropriate parameters/variables. The repo is disabled by default as users may prefer to use their own mirror.

Feedback:

That’s an unfortunate wording, foreman_scap_client lives in the client repo[1]. You shouldn’t really enable the plugin repo on the clients. And of course, we’ll fix that in the docs, thank you for pointing it out.

I'd like to try to fix those docs.

@aneta-petrova
Copy link
Member Author

Hi @adamruzicka, would this work?

plugins/foreman_openscap/1.0/index.md Outdated Show resolved Hide resolved
plugins/foreman_openscap/1.0/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM; tech wise: also makes sense to me.

@ekohl
Copy link
Member

ekohl commented Jan 28, 2025

@adamruzicka since you had feedback before, I'll leave it up to you.

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I don't have the green button pressing permissions here

@ekohl ekohl merged commit 41699f0 into theforeman:gh-pages Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants