Fixes #38197 - Allow unsetting settings with nil defaults #10435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Feb 10, 2025
|
|
||
| assert s.save | ||
| assert_nil s.value | ||
| assert_nil s.read_attribute(:value) |
There was a problem hiding this comment.
For my understanding, why this in addition to s.value?
There was a problem hiding this comment.
It is a bit of a stretch, but in theory it could happen that s.value would be nil, but the db field would be a nil serialized to yaml (---\n) instead of a proper null
ekohl
changed the title
ekohl
approved these changes
Feb 12, 2025
adamruzicka
force-pushed
the
nil-string-setting
branch
from
788ea5e to
31b0ce1
Compare
|
Done, test failures seem unrelated. |
ofedoren
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.