Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try mocha 3 #10422

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

try mocha 3 #10422

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 24, 2025

No description provided.

@ekohl
Copy link
Member

ekohl commented Jan 24, 2025

This part is now default (which I think was the only breaking change):

Mocha.configure do |config|
config.strict_keyword_argument_matching = true
end

Should we drop those lines?

@evgeni
Copy link
Member Author

evgeni commented Jan 24, 2025

If we bump the minimum version to 3, yeah.

This PR was just to see if things horribly break (they didn't 🎉) after I've seen the rc1 announcement by @floehopper

@ekohl
Copy link
Member

ekohl commented Jan 24, 2025

Yes, I noticed it was a draft and rc. Still nice it didn't crash & burn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants