Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema for App and Task: add versionInfo and slaveId (Marathon v11) #63

Closed
wants to merge 4 commits into from

Conversation

nathanleiby
Copy link
Contributor

See release notes for this API change: https://github.com/mesosphere/marathon/releases/tag/v0.11.0

"We now have versionInfo with lastConfigChangeAt and lastScalingAt in the
apps JSON of our API." (ee2c5a4)

"Marathon now saves the slaveID of newly launched tasks." (b832dd6)

See release notes for this API change:

"We now have versionInfo with lastConfigChangeAt and lastScalingAt in the
apps JSON of our API."

https://github.com/mesosphere/marathon/releases/tag/v0.11.0
@nathanleiby nathanleiby changed the title models/app: add versionInfo (Marathon v11) Update schema for App and Task: add versionInfo and slaveId (Marathon v11) Oct 6, 2015
@solarkennedy
Copy link
Contributor

Cool! Can you expand the matrix in the travis.yaml to be sure it will actually work against that version of marathon?

@nathanleiby
Copy link
Contributor Author

@solarkennedy expanded the matrix but in v11 build it's failing due to

Exception in thread "main" java.lang.UnsupportedClassVersionError: mesosphere/marathon/Main : Unsupported major.minor version 52.0

I think this is because Marathon v11 has a breaking change re: Java

Breaking Changes

Java 8 or higher is needed to run Marathon, since Java 6 and 7 support has reached end of life.

@solarkennedy
Copy link
Contributor

Gotcha. Can you bump the version of java installed so that we can properly test against marathon 11?

@itamaro
Copy link
Contributor

itamaro commented Nov 8, 2015

Hi, what's the status of this PR?

I'm working with a client lib built from this fork because I'm working against Marathon 0.11.1, so it doesn't work without it. I can confirm that it works fine, but definitely would rather see it merged :-)

@solarkennedy
Copy link
Contributor

Look like it has stalled. @itamaro if it is blocking you can you pick it up and make the tests pass? Otherwise I'll work on it in a couple of weeks as we upgrade.

@itamaro
Copy link
Contributor

itamaro commented Nov 12, 2015

I wish I could, @solarkennedy, but I can't figure out why it's failing.

Looking at the logs of this failure, looks like it's using jdk-9, which should be fine IIUC.

Trying to recreate this locally for further debugging (running make itests or MARATHONVERSION=0.11.0 make itests on an ubuntu 14.04 box with Docker), I get other errors:

The following packages have unmet dependencies:
 marathon : Depends: java8-runtime-headless but it is not installable
E: Unable to correct problems, you have held broken packages.
Service 'marathon' failed to build: The command '/bin/sh -c /root/install-marathon.sh' returned a non-zero code: 100
ERROR: InvocationError: '/bin/bash -c [[ -n $TRAVIS ]] || docker-compose build'
________________________________________________________________________________________ summary ________________________________________________________________________________________
ERROR:   itests: commands failed
make: *** [itests] Error 1

So I'll appreciate assistance with dealing with this, or I'll wait for you to get to it, as I can keep using this branch until then.

@nathanleiby
Copy link
Contributor Author

Sorry to drop this. Thank you for following up on the fix!
On Nov 14, 2015 12:13 PM, "Kyle Anderson" [email protected] wrote:

Closed #63 #63 via #68
#68.


Reply to this email directly or view it on GitHub
#63 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants