-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema for App and Task: add versionInfo and slaveId (Marathon v11) #63
Conversation
See release notes for this API change: "We now have versionInfo with lastConfigChangeAt and lastScalingAt in the apps JSON of our API." https://github.com/mesosphere/marathon/releases/tag/v0.11.0
Cool! Can you expand the matrix in the travis.yaml to be sure it will actually work against that version of marathon? |
@solarkennedy expanded the matrix but in v11 build it's failing due to
I think this is because Marathon v11 has a breaking change re: Java
|
Gotcha. Can you bump the version of java installed so that we can properly test against marathon 11? |
Hi, what's the status of this PR? I'm working with a client lib built from this fork because I'm working against Marathon 0.11.1, so it doesn't work without it. I can confirm that it works fine, but definitely would rather see it merged :-) |
Look like it has stalled. @itamaro if it is blocking you can you pick it up and make the tests pass? Otherwise I'll work on it in a couple of weeks as we upgrade. |
I wish I could, @solarkennedy, but I can't figure out why it's failing. Looking at the logs of this failure, looks like it's using jdk-9, which should be fine IIUC. Trying to recreate this locally for further debugging (running
So I'll appreciate assistance with dealing with this, or I'll wait for you to get to it, as I can keep using this branch until then. |
Sorry to drop this. Thank you for following up on the fix!
|
See release notes for this API change: https://github.com/mesosphere/marathon/releases/tag/v0.11.0
"We now have versionInfo with lastConfigChangeAt and lastScalingAt in the
apps JSON of our API." (ee2c5a4)
"Marathon now saves the slaveID of newly launched tasks." (b832dd6)