Add accepted_resource_role kwarg for Marathon 0.9.0 support #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa! |
|
Well, the tests pass! If there is any other api-breaking change on 0.9.0, then we are not itesting against them so we won't know yet! This was exactly the thing that made me comment out 0.9.0 before, it is nice to see this was the only thing (so far) that was preventing this. Can you update the README.md + CHANGELOG as well and bump the version number (but note it as not-released yet) |
|
thanks, I needed this too |
solarkennedy
added a commit
that referenced
this pull request
Jul 21, 2015
Add accepted_resource_role kwarg for Marathon 0.9.0 support
|
Thanks @keshavdv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.