Upstream merge - Add itest framework and fix regex #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the regex from upstream marathon as-is
First pass at adding an itest framework
Added travis integration
Added a matrix of marathon versions to test against
Added complex app with healthchecks in the itests
solarkennedy
added a commit
that referenced
this pull request
Jul 14, 2015
Upstream merge - Add itest framework and fix regex
|
@mbabineau I'm going to continue working against my for because it has the travis feedback against which marathon versions my code breaks/fixes. Please turn on Travis-ci https://travis-ci.org/profile/thefactory to activate that same badge on this repo. |
|
Sweet, enabled - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds travis integration, so that we know when things start breaking.
I've commented out 0.9.0 because these bindings do not work against it, and travis reflects that!
The tests are easily reproducible with "make itest", given you have python and docker installed.
Additionally I've fixed the regex thing by using the upstream regex from marathon.
Closes #44 #45
@mbabineau I do not have admin rights to the repo, can you enable travis integration:
https://travis-ci.org/profile/thefactory