Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forcePullImage parameter for the container model #31

Merged
merged 1 commit into from
May 28, 2015

Conversation

solarkennedy
Copy link
Contributor

This is a new parameter for the upcoming 8.2 release added here:
d2iq-archive/marathon@2a65700

This is my first time in this code base. I think I'm doing it right?

@mbabineau
Copy link
Member

Pretty much, but could you change it to force_pull_image instead? (PEP-8)

It'll automatically be translated to camel case:
https://github.com/thefactory/marathon-python/blob/master/marathon/models/base.py#L22
https://github.com/thefactory/marathon-python/blob/master/marathon/util.py#L50

Thanks!

@solarkennedy
Copy link
Contributor Author

Ah! Updated.

@mbabineau
Copy link
Member

👍 excellent, thanks for the PR!

mbabineau added a commit that referenced this pull request May 28, 2015
Added forcePullImage parameter for the container model
@mbabineau mbabineau merged commit 1ee0822 into thefactory:master May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants