Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/marathon constraint model improvements #229

Merged
merged 5 commits into from
Nov 2, 2017
Merged

Feature/marathon constraint model improvements #229

merged 5 commits into from
Nov 2, 2017

Conversation

diogommartins
Copy link
Contributor

  • Adding tests to MarathonConstraint methods
  • Adding MarathonConstraint.from_string classmethod

@solarkennedy
Copy link
Contributor

Can you address the lint failures?

@diogommartins
Copy link
Contributor Author

Fixed

@diogommartins
Copy link
Contributor Author

Is there something else you want me to do?

@solarkennedy
Copy link
Contributor

Nope! Thank you.

@solarkennedy solarkennedy merged commit 96691d6 into thefactory:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogommartins @solarkennedy