Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make travis automatically upload to pypi on new tags #223

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

solarkennedy
Copy link
Contributor

No description provided.

@solarkennedy solarkennedy self-assigned this Oct 16, 2017
Copy link
Contributor

@nhandler nhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship It! But see my comment for a change we will likely want to make to improve this.

secure: "Wl8GWxsfPy4KoORYH26N3FllvMeWrifzeCbEx2Af4corcBQl43heeiFRRTlUOcSX0TIasER21PUvQ0R0cAgCjfknDb3SOROcRtcSBe16+cMmvwysfxcAx2OcF1UYBPY8e/qOsGge2Zyzx2PAPNEmJoWKbIT3vUJ4WvlLVeGYdJ0="
on:
tags: true
condition: MARATHONVERSION == "1.4.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you included this line, but I really don't like it. We will definitely forget to bump this version number as we change the marathon versions we test against. It also will upload to pypi even if tests are failing on older versions of Marathon (although in practice, those PRs should not be merged in the first place).

The better solution will likely be https://docs.travis-ci.com/user/build-stages , but they are still under Beta (and I'm not sure how well they work in practice).

@solarkennedy solarkennedy merged commit 1051c7f into master Oct 16, 2017
@solarkennedy solarkennedy deleted the travis_pypi branch October 16, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants