Possibility to send the full object to Marathon on update #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change setting the value of some keys of an application (like 'health_checks' or 'constraints') from a collection that contains objects to an empty collection and then calling `MarathonClient.update_app` to update the application resulted in health checks or constraints never being updated. The cause of this was that `MarathonClient.update_app` always called `app.to_json(minmal=True)` which kicks out all empty collections. This change lets the developer choose whether `minimal` should be `True` or `False`. It retains the original behaviour through a default.
|
Great catch, sorry for the delay. Thanks for the PR! |
mbabineau
added a commit
that referenced
this pull request
Mar 10, 2015
Possibility to send the full object to Marathon on update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change setting the value of some keys of an application
(like 'health_checks' or 'constraints') from a collection that contains objects
to an empty collection and then calling
MarathonClient.update_appto update theapplication resulted in health checks or constraints never being updated.
The cause of this was that
MarathonClient.update_appalways calledapp.to_json(minmal=True)which kicks out all empty collections.This change lets the developer choose whether
minimalshould beTrueorFalse.It retains the original behaviour through a default.