There are cases where this check stack traces #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if you're trying to compare a MarathonObject with ``None`` or ``str()`` those won't have the ``__dict__`` attribute. Another approach was to test if the ``__dict__`` attribute was part of ``other`` but it introspection feels a bit more off than this.
kruxErinWillingham
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if you're trying to compare a MarathonObject with
Noneorstr()those won't have the__dict__attribute. Another approach wasto test if the
__dict__attribute was part ofotherbut it introspectionfeels a bit more off than this.