Add update_apps method to client #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the python API only supports updating a single app in one call. The REST API however, support a PUT call to the /v2/apps path that allows for updating several apps in one go. This PR exposes this call in the form of an update_apps function which takes in a list of MarathonApp objects. Taking the possible convenience aside for a moment, my actual motivation for this was performance. We perform update operations on 10s of applications at a time. Doing these one by one would take up to a few minutes. Implementing this has trimmed it down to under 10 seconds. Hopefully the actual implementation is up to common convention for marathon-python, but have no issue changing whatever and submitting a new PR if something is off and it will help to get this merged.
Thanks,
Kevin