-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization of imgui causes build error '_FringeScale': is not a member of 'ImDrawList' #25
Comments
This change mage _FringeScale extension optional and make canvas compile without it. SFINAE is used to detect if member variable is present. Fringe scale extension to ImDrawList make zoomed geometry look sharp. It is available here: https://github.com/thedmd/imgui/tree/feature/draw-list-fringe-scale
I made use of I'm aiming to use vanilla copy of ImGui. Last month I made changes that made this goal viable.
|
ImGuiKey_D and ImGuiKey_F are used in node editor only if they are defined in ImGuiKey_ enum. This commit can be removed when/if ocornut/imgui#2625 PR will be merged.
This change mage _FringeScale extension optional and make canvas compile without it. SFINAE is used to detect if member variable is present. Fringe scale extension to ImDrawList make zoomed geometry look sharp. It is available here: https://github.com/thedmd/imgui/tree/feature/draw-list-fringe-scale
ImGuiKey_D and ImGuiKey_F are used in node editor only if they are defined in ImGuiKey_ enum. This commit can be removed when/if ocornut/imgui#2625 PR will be merged.
I tested changes on vanilla copy of ImGui and node editor compile fine without errors. You can now use node editor with your local copy of ImGui. ⚡ As a note, project had cleanup recently:
Please let me know if you need anything. |
This change mage _FringeScale extension optional and make canvas compile without it. SFINAE is used to detect if member variable is present. Fringe scale extension to ImDrawList make zoomed geometry look sharp. It is available here: https://github.com/thedmd/imgui/tree/feature/draw-list-fringe-scale
ImGuiKey_D and ImGuiKey_F are used in node editor only if they are defined in ImGuiKey_ enum. This commit can be removed when/if ocornut/imgui#2625 PR will be merged.
I already had an official copy of the imgui library in my program and when I added imgui-node-editor, I get this build error when my codebase references the official imgui.h:
The following commit added _FringeScale to ThirdParty/imgui/imgui.h:
11d2dca
However, I don't see any reference to it in the official imgui repo:
https://github.com/ocornut/imgui
This customization to imgui means I have to use your custom version of imgui throughout my codebase. Even when I built imgui-node-editor, other libraries in my codebase would reference the official imgui.h, which doesn't have
_FringeScale
. I suggest contributing this change and any other customizations to the imgui project and only consume them once they are merged to master.If you really want a custom imgui, please rename the source and the public interfaces so that it can coexist with the official imgui library.
The text was updated successfully, but these errors were encountered: