Clean up in aisle xml

thechangelog · Jul 19, 2024 · df0f970 · df0f970
1 parent fd040d8
commit df0f970
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/lib/changelog_web/xml/chapters.ex b/lib/changelog_web/xml/chapters.ex
@@ -5,7 +5,9 @@ defmodule ChangelogWeb.Xml.Chapters do
   Returns a full XML document structure ready to be sent to Xml.generate/1
   """
   def document(chapters, namespace \\ nil) do
-    chapters(chapters, namespace) |> XmlBuilder.document()
+    chapters
+    |> chapters(namespace)
+    |> XmlBuilder.document()
   end
 
   def chapters(chapters, namespace \\ nil) do

diff --git a/lib/changelog_web/xml/feed.ex b/lib/changelog_web/xml/feed.ex
@@ -32,14 +32,14 @@ defmodule ChangelogWeb.Xml.Feed do
         {"itunes:summary", nil, feed.description},
         {"itunes:image", %{href: PodcastView.cover_url(feed)}},
         {"itunes:owner", nil, Xml.itunes_owner()},
-        Enum.map(episodes, fn episode -> episode(feed, episode) end)
+        Enum.map(episodes, fn episode -> item(feed, episode) end)
       ]
       |> List.flatten()
       |> ListKit.compact()
     }
   end
 
-  def episode(feed, episode) do
+  def item(feed, episode) do
     {:item, nil,
      [
        {:title, nil, FeedView.custom_episode_title(feed, episode)},

diff --git a/lib/changelog_web/xml/plusplus.ex b/lib/changelog_web/xml/plusplus.ex
@@ -32,16 +32,14 @@ defmodule ChangelogWeb.Xml.Plusplus do
         {"itunes:explicit", nil, "no"},
         {"itunes:summary", nil, "Thank you for subscribing to Changelog++!"},
         {"itunes:image", %{href: url(~p"/images/podcasts/plusplus-original.png")}},
-        {"itunes:category", nil, Xml.itunes_category()},
-        Xml.itunes_sub_category(podcast),
-        Enum.map(episodes, fn episode -> episode(podcast, episode) end)
+        Enum.map(episodes, fn episode -> item(podcast, episode) end)
       ]
       |> List.flatten()
       |> ListKit.compact()
     }
   end
 
-  def episode(podcast, episode) do
+  def item(podcast, episode) do
     {:item, nil,
      [
        {:title, nil, FeedView.episode_title(podcast, episode)},

diff --git a/lib/changelog_web/xml/podcast.ex b/lib/changelog_web/xml/podcast.ex
@@ -42,14 +42,14 @@ defmodule ChangelogWeb.Xml.Podcast do
         {"podcast:funding", %{url: "https://changelog.com/++"},
          "Support our work by joining Changelog++"},
         Enum.map(podcast.active_hosts, fn p -> Xml.person(p, "host") end),
-        Enum.map(episodes, fn episode -> episode(podcast, episode) end)
+        Enum.map(episodes, fn episode -> item(podcast, episode) end)
       ]
       |> List.flatten()
       |> ListKit.compact()
     }
   end
 
-  def episode(podcast, episode) do
+  def item(podcast, episode) do
     {:item, nil,
      [
        {:title, nil, FeedView.episode_title(podcast, episode)},