Clean up page titles

lib/changelog_web/meta/admin_title.ex

@@ -4,15 +4,8 @@ defmodule ChangelogWeb.Meta.AdminTitle do
 
   @suffix "Admin"
 
-  def get(type, conn) do
+  def get(conn) do
     assigns = Meta.prep_assigns(conn)
-
-    case type do
-      :page -> page_title(assigns)
-    end
-  end
-
-  defp page_title(assigns) do
     assigns |> title() |> put_suffix()
   end
 

lib/changelog_web/meta/title.ex

@@ -15,28 +15,16 @@ defmodule ChangelogWeb.Meta.Title do
     SearchView
   }
 
-  @default "News and podcasts for developers"
+  @default "Podcasts for developers"
 
-  def get(type, conn) do
+  def get(conn) do
     view = Phoenix.Controller.view_module(conn)
     template = Phoenix.Controller.view_template(conn)
     assigns = Map.merge(conn.assigns, %{view_module: view, view_template: template})
 
-    case type do
-      :page -> page_title(assigns)
-      :share -> share_title(assigns)
-    end
-  end
-
-  defp page_title(assigns) do
-    [title(assigns) || @default, "Changelog"]
-    |> Enum.reject(&is_nil/1)
-    |> Enum.join(" |> ")
+    title(assigns) || @default
   end
 
-  # no need for the suffix on these
-  defp share_title(assigns), do: title(assigns) || @default
-
   # Search views
   defp title(%{view_module: SearchView, view_template: "search.html", query: ""}), do: "Search"
 

lib/changelog_web/templates/episode/embed.html.eex

@@ -4,7 +4,7 @@
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1">
-    <title><%= Meta.Title.get(:page, @conn) %></title>
+    <title><%= Meta.Title.get(@conn) %></title>
     <meta name="description" content="<%= Meta.Description.get(@conn) %>">
     <meta name="copyright" content="Changelog Media LLC">
     <link rel="stylesheet" href="<%= url(~p"/css/embed.css") %>">

lib/changelog_web/templates/layout/admin.html.eex

@@ -6,7 +6,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=1">
     <meta name="csrf-token" content={Plug.CSRFProtection.get_csrf_token()} />
 
-    <title><%= Meta.AdminTitle.get(:page, @conn) %></title>
+    <title><%= Meta.AdminTitle.get(@conn) %></title>
     <link rel="stylesheet" href="<%= url(~p"/css/admin.css") %>">
   </head>
 

lib/changelog_web/templates/layout/app.html.eex

@@ -5,14 +5,14 @@
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1">
     <meta name="theme-color" content="#59B287">
-    <title><%= Meta.Title.get(:page, @conn) %></title>
+    <title><%= Meta.Title.get(@conn) %></title>
     <link rel="canonical" href="<%= Meta.Url.get(:canonical, @conn) || current_url(@conn) %>">
     <meta name="description" content="<%= Meta.Description.get(@conn) %>">
     <meta name="copyright" content="Changelog Media LLC">
   <% twitter_card_type = Meta.Twitter.get(:card_type, @conn) %>
     <meta name="twitter:card" content="<%= twitter_card_type %>">
     <meta name="twitter:site" content="@Changelog">
-    <meta name="twitter:title" content="<%= Meta.Title.get(:share, @conn) |> escaped()
+    <meta name="twitter:title" content="<%= Meta.Title.get(@conn) |> escaped()
  %>">
     <meta name="twitter:description" content="<%= Meta.Description.get(@conn) |> escaped() %>">
   <%= if twitter_card_type == "player" do %>
@@ -31,7 +31,7 @@
   <% end %>
     <meta property="og:url" content="<%= current_url(@conn) %>">
     <meta property="og:type" content="website">
-    <meta property="og:title" content="<%= Meta.Title.get(:share, @conn) |> escaped() %>">
+    <meta property="og:title" content="<%= Meta.Title.get(@conn) |> escaped() %>">
     <meta property="og:description" content="<%= Meta.Description.get(@conn) |> escaped() %>">
     <meta property="og:site_name" content="Changelog">
     <meta property="og:locale" content="en_US">