Address a couple compiler warnings

thechangelog · May 10, 2023 · 5524bd9 · 5524bd9
1 parent a31058d
commit 5524bd9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/changelog/schema/episode/episode.ex b/lib/changelog/schema/episode/episode.ex
@@ -144,7 +144,7 @@ defmodule Changelog.Episode do
   def with_podcast_slug(query, nil), do: query
 
   def with_podcast_slug(query, slug),
-    do: from(q in query, join: p in Podcast, where: q.podcast_id == p.id, where: p.slug == ^slug)
+    do: from(q in query, join: p in Podcast, on: true, where: q.podcast_id == p.id, where: p.slug == ^slug)
 
   def with_transcript(query \\ __MODULE__),
     do: from(q in query, where: fragment("? != '{}'", q.transcript))

diff --git a/lib/changelog_web/controllers/admin/person_controller.ex b/lib/changelog_web/controllers/admin/person_controller.ex
@@ -211,8 +211,7 @@ defmodule ChangelogWeb.Admin.PersonController do
     |> redirect_next(params, Routes.admin_person_path(conn, :index))
   end
 
-  def masq(conn = %{assigns: %{person: person}}, params) do
-
+  def masq(conn = %{assigns: %{person: person}}, _params) do
     conn
     |> put_session("id", person.id)
     |> configure_session(renew: true)