Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Create Occitan translation #816

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

ensag-dev
Copy link
Contributor

Hello,
I hope this PR is well formed

Regards

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for ananke-theme failed.

Name Link
🔨 Latest commit 1ae15a6
🔍 Latest deploy log https://app.netlify.com/sites/ananke-theme/deploys/6787639e5461600008a382a5

@davidsneighbour
Copy link
Collaborator

davidsneighbour commented Jan 15, 2025

It looks ok. Two notes:

  • I am not sure if oc is the right language code or if we will have to use some form of ES_oc - will investigate. That's just to go sure and due to my own knowledge deficits. This is connected to ISO 639-1, but it's more about working in connection with Hugo.
  • You have a "Recent" there in the third group (line 8). Is that because there is no wording for that or did you miss it? I assume it's not Occitania?

Also, I am starting to attribute "code ownership" for translations to the people who translated it. Are you ok to be attributed with ensag-dev in .github/CODEOWNERS? The concept is explained here in the docs. Basically you own the translation, because no one else (except anyone adding changes later on) knows the language ;)

PS: ignore the Netlify deploy errors. That's a config issue.

@ensag-dev
Copy link
Contributor Author

Hello,

the iso code would be oc_FR, oc_ES or oc_IT, the language code then the country.
Yes "recent" is the same in Occitan :)

@davidsneighbour
Copy link
Collaborator

I am merging this. The RFC Hugo is using is RFC5646 and oc is in there.

@davidsneighbour davidsneighbour merged commit 36bca91 into theNewDynamic:main Jan 17, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants