Use of .RelPermalink brokes the multilingual host functionality #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://gohugo.io/content-management/multilingual/#configure-multilingual-multihost this functionality needs to create the language links with .Permalink
✅ Deploy Preview for gohugo-ananke-theme-demo canceled.
|
ricard2k
changed the title
|
You can see the patch working in: |
regisphilibert
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Hi @ricard2k and thank you for this.
I understand the motivation but I don't think we should enforce .Permalink for everyone for such an edge-case.
I'm not sure there is a way to know if the current project is multi host, but if there is, we should test that before using .Permalink here rather than .RelPermalink.
If this test is not possible then we should add a global boolean setting to the theme localizationMultiHost(for example) and test it instead.
Of course the latter would require an addition to the read me.
Thanks a ton!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gohugo.io/content-management/multilingual/#configure-multilingual-multihost
this functionality needs to create the language links with .Permalink