433 fix tags layout #472
Merged
433 fix tags layout #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@budparr this is design |
regisphilibert
requested review from
regisphilibert
and removed request for
budparr
regisphilibert
requested changes
Jan 19, 2022
There was a problem hiding this comment.
Hi @fullstack-jack and thank you for this. The theme is using a utility class library called tachyon so we don't need custom css for this fix. You can simply apply di class on the li. Could you do so and remove the changes you made to _styles.css?
+ <ul class="pa0">
- <ul class="pa0 tags">
{{ range .Params.tags }}
+ <li class="list di">
- <li class="list">
<a href="{{ "/tags/" | relLangURL }}{{ . | urlize }}" class="link f5 grow no-underline br-pill ba ph3 pv2 mb2 dib black sans-serif">
|
@regisphilibert Thanks for the review, I didn't know about tachyon so it was good to look into. I've made the changes you suggested. |
Remicck
pushed a commit
to Remicck/gohugo-theme-ananke
that referenced
this pull request
Mar 7, 2022
* Added tags class to tags list * display tags inline * Added di class to list * Removed tags class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433